Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts to Fix Temperature + Makes It More Realistic in the Face of Extreme Temperatures #3512

Merged
merged 41 commits into from
Dec 3, 2024

Conversation

rye-rice
Copy link
Member

@rye-rice rye-rice commented Oct 9, 2024

About The Pull Request

Zym's temperture PR apparently doesn't work as intended, this is not because of a coding error but simply because SS13 humans are extremely fucking durable somehow

This attemps to fix it by making humands much more squishy and easier for players to notice cold/warm areas without it being in the danger zone.

This also adds a fun mechanic where staying hydrated reduces burn damage taken from hot air.

And in order to fine tune some planet's tempertures, rockplanet and beachplanet's gases have been randomized.

ports tgstation/tgstation#82336 as well, a nice cold breath effect!

Why It's Good For The Game

you should no longer be fine in -50 C nor 100 C, this may be frustrating, but holy shit you should NOT be fine at 100C. Hardsuit negates this completely

Changelog

🆑
add: Melbert, rye-rice
balance: you will no longer be fine at 100 c, nor 50 c, you should also NOT be fine at -100 c either. clothing helps.
fix: should be able to tell slighlty chilly tempertures
qol: Breathing cold air now has a particle effect associated, careful not to let your glasses fog up.
qol: Breathing cold air will now occasionally make your spaceman shiver. Brrr.
/:cl:

@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels Oct 9, 2024
@generalthrax
Copy link
Contributor

generalthrax commented Oct 9, 2024

Might be worth adjusting planet temperatures around the board. It's pretty much only beach and jungle that have Real Temperatures

Having to need specialty gear for certain worlds is fine and all, but every other planet being -93C is a little intense.

@thgvr
Copy link
Member

thgvr commented Oct 10, 2024

note thati need temperture to not be jank where it stablizes, doesnt for 2 seconds, then stablizes, please i need help with coding this part

that ain't gonna be fixable without a whole rework as it relies on life processing fairly sure

@thearbiber
Copy link

This is extremely intense, wearing hardsuits can make you heat up to take damage sometimes and winter coats don't even work on sand or ice planets. Have not tried them on rock planets yet. Also, breathing out of an oxygen tank makes the air you're breathing cold to the point you also take damage from that as well?

@Leon9621
Copy link

This is extremely intense, wearing hardsuits can make you heat up to take damage sometimes and winter coats don't even work on sand or ice planets. Have not tried them on rock planets yet. Also, breathing out of an oxygen tank makes the air you're breathing cold to the point you also take damage from that as well?

TBF, just dealt with winter coats on a few cold planets, they work if you put the hood up

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 15, 2024
@Imaginos16 Imaginos16 changed the title shitty attempt to fix temperture + makes people much more realistic in the face of extreme tempertures Attempts to Fix Temperature + Makes It More Realistic in the Face of Extreme Temperatures Oct 18, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 24, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@generalthrax
Copy link
Contributor

Jungles at the temperature they're at are perpetually slippery with water vapour getting on every single tile

@rye-rice rye-rice removed the request for review from FalloutFalcon November 22, 2024 00:41
@rye-rice rye-rice mentioned this pull request Dec 2, 2024
Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine. balance may need to be adjusted,

@thgvr
Copy link
Member

thgvr commented Dec 3, 2024

untangle this later, fix the breath particles later or remove them, they suck and don't support species.

@thgvr thgvr added this pull request to the merge queue Dec 3, 2024
Merged via the queue into shiptest-ss13:master with commit 274becd Dec 3, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants